From f6ac2e44bb4e3d6685268481c16abfb60191b93c Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Sat, 11 Jul 2020 15:16:53 -0400 Subject: [PATCH] rtpsrc: Always set rtcp socket address Regardless if it's multicast or not, set the address property to match the element address. This is the address of the interface to listen to, which is expected to be ANY in most cases, but should be honnored even for RTCP non-multicast case. This also fixes an assertion if the address is not a parsable IPv4 or IPv6 string. Part-of: --- gst/rtp/gstrtpsrc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/gst/rtp/gstrtpsrc.c b/gst/rtp/gstrtpsrc.c index aa83c503b9..385f479f39 100644 --- a/gst/rtp/gstrtpsrc.c +++ b/gst/rtp/gstrtpsrc.c @@ -184,17 +184,9 @@ gst_rtp_src_set_property (GObject * object, guint prop_id, break; } case PROP_ADDRESS:{ - GInetAddress *addr; - gst_uri_set_host (self->uri, g_value_get_string (value)); g_object_set_property (G_OBJECT (self->rtp_src), "address", value); - - addr = g_inet_address_new_from_string (gst_uri_get_host (self->uri)); - if (g_inet_address_get_is_multicast (addr)) { - g_object_set (self->rtcp_src, "address", gst_uri_get_host (self->uri), - NULL); - } - g_object_unref (addr); + g_object_set_property (G_OBJECT (self->rtcp_src), "address", value); break; } case PROP_PORT:{