From f506a3e0ff1ef7d07d854325b7b33005ccf16299 Mon Sep 17 00:00:00 2001
From: He Junyan <junyan.he@intel.com>
Date: Tue, 2 Mar 2021 13:07:04 +0800
Subject: [PATCH] gl: download: Fix a caps memory leak in
 prepare_output_buffer().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1058>
---
 ext/gl/gstgldownloadelement.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ext/gl/gstgldownloadelement.c b/ext/gl/gstgldownloadelement.c
index f1f0f6c448..87c0600e43 100644
--- a/ext/gl/gstgldownloadelement.c
+++ b/ext/gl/gstgldownloadelement.c
@@ -484,6 +484,7 @@ gst_gl_download_element_prepare_output_buffer (GstBaseTransform * bt,
     } else {
       GstCaps *src_caps;
       GstCapsFeatures *features;
+      gboolean ret;
 
       src_caps = gst_pad_get_current_caps (bt->srcpad);
       src_caps = gst_caps_make_writable (src_caps);
@@ -492,7 +493,10 @@ gst_gl_download_element_prepare_output_buffer (GstBaseTransform * bt,
       g_atomic_int_set (&dl->try_dmabuf_exports, FALSE);
       dl->mode = GST_GL_DOWNLOAD_MODE_PBO_TRANSFERS;
 
-      if (!gst_base_transform_update_src_caps (bt, src_caps)) {
+      ret = gst_base_transform_update_src_caps (bt, src_caps);
+      gst_caps_unref (src_caps);
+
+      if (!ret) {
         GST_ERROR_OBJECT (bt, "DMABuf exportation didn't work and system "
             "memory is not supported.");
         return GST_FLOW_NOT_NEGOTIATED;