From f4afec4657f5dbb05f149678f02202a752c2a0e1 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Fri, 26 Sep 2014 12:28:10 +1000 Subject: [PATCH] gloverlay: free the image memory every time the location changes fixes a memory leak --- ext/gl/gstgloverlay.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/ext/gl/gstgloverlay.c b/ext/gl/gstgloverlay.c index cba5a6993b..9af1c301d6 100644 --- a/ext/gl/gstgloverlay.c +++ b/ext/gl/gstgloverlay.c @@ -475,12 +475,11 @@ gst_gl_overlay_filter_texture (GstGLFilter * filter, guint in_tex, GstGLOverlay *overlay = GST_GL_OVERLAY (filter); if (overlay->location_has_changed) { - if (overlay->location == NULL) { - if (overlay->image_memory) { - gst_memory_unref ((GstMemory *) overlay->image_memory); - overlay->image_memory = NULL; - } - } else { + if (overlay->image_memory) { + gst_memory_unref ((GstMemory *) overlay->image_memory); + overlay->image_memory = NULL; + } + if (overlay->location != NULL) { if ((overlay->type_file = gst_gl_overlay_load_png (filter)) == 0) { if ((overlay->type_file = gst_gl_overlay_load_jpeg (filter)) == 0) { return FALSE;