From f3e707c71c9a0c4dacc40168fe5c83f49ded846e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 24 Oct 2024 20:12:55 +0300 Subject: [PATCH] rtsp-server: Remove pointless assertions that can happen if client provides invalid rates Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3731 Fixes CVE-2024-44331 Part-of: --- subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-media.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-media.c b/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-media.c index fa959fef3e..0b303c94b4 100644 --- a/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-media.c +++ b/subprojects/gst-rtsp-server/gst/rtsp-server/rtsp-media.c @@ -2979,15 +2979,13 @@ gst_rtsp_media_get_rates (GstRTSPMedia * media, gdouble * rate, first_stream = FALSE; } else { if (save_rate != *rate || save_applied_rate != *applied_rate) { - /* diffrent rate or applied_rate, weird */ - g_assert (FALSE); + /* different rate or applied_rate, weird */ result = FALSE; break; } } } else { - /* complete stream withot rate and applied_rate, weird */ - g_assert (FALSE); + /* complete stream without rate and applied_rate, weird */ result = FALSE; break; }