From f1a52c5ea099352e66f0abdb50f911dfd9b3f392 Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Fri, 18 Nov 2022 01:49:43 +0900 Subject: [PATCH] av1decoder: Fix wrong spatial layer validation Highest spatial id and temporal id is independent, and should not drop temporal enhance layer by the previous condition. Note that the decision for dropping OBU based on operation point is being handled in gst_av1_parser_identify_one_obu() already. Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1585 Part-of: --- .../gst-plugins-bad/gst-libs/gst/codecs/gstav1decoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gstav1decoder.c b/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gstav1decoder.c index 9808af8292..f537d39a6f 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gstav1decoder.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gstav1decoder.c @@ -712,11 +712,11 @@ gst_av1_decoder_handle_frame (GstVideoDecoder * decoder, goto out; } - if (priv->current_picture->temporal_id > self->highest_spatial_layer) { + if (priv->current_picture->spatial_id > self->highest_spatial_layer) { ret = GST_FLOW_ERROR; GST_VIDEO_DECODER_ERROR (self, 1, STREAM, DECODE, - ("current picture temporal_id %d should not be higher than " - "highest spatial layer %d", priv->current_picture->temporal_id, + ("current picture spatial_id %d should not be higher than " + "highest spatial layer %d", priv->current_picture->spatial_id, self->highest_spatial_layer), (NULL), ret); goto out; }