From f000bbe9248027083a8be3d1a31fc800fd752515 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 6 Mar 2012 12:24:53 +0100 Subject: [PATCH] tee: Fix 'use of logical '&&' with constant operand' compiler warning This is actually a real bug. --- plugins/elements/gsttee.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/elements/gsttee.c b/plugins/elements/gsttee.c index 6b875a78a0..f1ec8a4f01 100644 --- a/plugins/elements/gsttee.c +++ b/plugins/elements/gsttee.c @@ -859,7 +859,7 @@ gst_tee_sink_activate_push (GstPad * pad, gboolean active) tee = GST_TEE (GST_OBJECT_PARENT (pad)); GST_OBJECT_LOCK (tee); - tee->sink_mode = active && GST_ACTIVATE_PUSH; + tee->sink_mode = (active ? GST_ACTIVATE_PUSH : GST_ACTIVATE_NONE); if (active && !tee->has_chain) goto no_chain; @@ -912,7 +912,7 @@ gst_tee_src_activate_pull (GstPad * pad, gboolean active) if (pad == tee->pull_pad) tee->pull_pad = NULL; } - tee->sink_mode = active && GST_ACTIVATE_PULL; + tee->sink_mode = (active ? GST_ACTIVATE_PULL : GST_ACTIVATE_NONE); GST_OBJECT_UNLOCK (tee); gst_object_unref (tee);