From ed28bde0a61ed78a78a1f1607dd0b592c22294e7 Mon Sep 17 00:00:00 2001 From: Philippe Normand Date: Tue, 10 Dec 2024 16:15:09 +0000 Subject: [PATCH] webrtc: Simplify fmtp handling in codec stats Parsing the whole caps as SDP media only to retrieve the fmtp field afterwards seems a bit superfluous. By looking up the a-fmtp attribute directly the number of allocations in this function gets down a bit. Part-of: --- .../gst-plugins-bad/ext/webrtc/gstwebrtcstats.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c index d859005f28..2edb46b1d8 100644 --- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c +++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c @@ -815,8 +815,8 @@ _get_codec_stats_from_pad (GstWebRTCBin * webrtc, GstPad * pad, GstStructure *caps_s = gst_caps_get_structure (caps, 0); gint pt; const gchar *encoding_name, *media, *encoding_params; - GstSDPMedia sdp_media = { 0 }; guint channels = 0; + const gchar *fmtp; if (gst_structure_get_int (caps_s, "payload", &pt)) gst_structure_set (stats, "payload-type", G_TYPE_UINT, pt, NULL); @@ -852,15 +852,10 @@ _get_codec_stats_from_pad (GstWebRTCBin * webrtc, GstPad * pad, else gst_structure_set (stats, "codec-type", G_TYPE_STRING, "encode", NULL); - gst_sdp_media_init (&sdp_media); - if (gst_sdp_media_set_media_from_caps (caps, &sdp_media) == GST_SDP_OK) { - const gchar *fmtp = gst_sdp_media_get_attribute_val (&sdp_media, "fmtp"); - - if (fmtp) { - gst_structure_set (stats, "sdp-fmtp-line", G_TYPE_STRING, fmtp, NULL); - } + fmtp = gst_structure_get_string (caps_s, "a-fmtp"); + if (fmtp) { + gst_structure_set (stats, "sdp-fmtp-line", G_TYPE_STRING, fmtp, NULL); } - gst_sdp_media_uninit (&sdp_media); /* FIXME: transportId */ }