From e85f8c8ab6c0a13d4581ae99c814e28bcd3a4569 Mon Sep 17 00:00:00 2001 From: "Joshua M. Doe" Date: Fri, 26 Mar 2010 18:19:00 +0100 Subject: [PATCH] baseparse: Send NEWSEGMENT event with correct start and position Instead of taking the last stop (which could be buffer endtime instead of starttime) always take the buffer starttime. Fixes bug #614016. --- gst/audioparsers/gstbaseparse.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/gst/audioparsers/gstbaseparse.c b/gst/audioparsers/gstbaseparse.c index a5c86601bb..f119e6d3fd 100644 --- a/gst/audioparsers/gstbaseparse.c +++ b/gst/audioparsers/gstbaseparse.c @@ -1015,6 +1015,7 @@ GstFlowReturn gst_base_parse_push_buffer (GstBaseParse * parse, GstBuffer * buffer) { GstFlowReturn ret = GST_FLOW_OK; + GstClockTime last_start = GST_CLOCK_TIME_NONE; GstClockTime last_stop = GST_CLOCK_TIME_NONE; GST_LOG_OBJECT (parse, @@ -1039,9 +1040,10 @@ gst_base_parse_push_buffer (GstBaseParse * parse, GstBuffer * buffer) gst_base_parse_update_bitrates (parse, buffer); if (GST_BUFFER_TIMESTAMP_IS_VALID (buffer)) - last_stop = GST_BUFFER_TIMESTAMP (buffer); - if (last_stop != GST_CLOCK_TIME_NONE && GST_BUFFER_DURATION_IS_VALID (buffer)) - last_stop += GST_BUFFER_DURATION (buffer); + last_start = GST_BUFFER_TIMESTAMP (buffer); + if (last_start != GST_CLOCK_TIME_NONE + && GST_BUFFER_DURATION_IS_VALID (buffer)) + last_stop = last_start + GST_BUFFER_DURATION (buffer); /* should have caps by now */ g_return_val_if_fail (GST_PAD_CAPS (parse->srcpad), GST_FLOW_ERROR); @@ -1052,13 +1054,13 @@ gst_base_parse_push_buffer (GstBaseParse * parse, GstBuffer * buffer) * actual frame data might lead subclass to different timestamps, * so override segment start from what is supplied there */ if (G_UNLIKELY (parse->pending_segment && !parse->priv->passthrough && - GST_CLOCK_TIME_IS_VALID (last_stop))) { + GST_CLOCK_TIME_IS_VALID (last_start))) { gst_event_unref (parse->pending_segment); /* stop time possibly lost this way, * but unlikely and not really supported */ parse->pending_segment = gst_event_new_new_segment (FALSE, parse->segment.rate, - parse->segment.format, last_stop, -1, last_stop); + parse->segment.format, last_start, -1, last_start); } /* and should then also be linked downstream, so safe to send some events */