From dedbbdd41b9d510f8c1a667182b796d5cbcbbf65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Sun, 19 Apr 2015 11:19:03 +0200 Subject: [PATCH] vaapidecode: reduce logging noise When a frame is rejected by downstream, the message is logged twice. This patch removes one of those logging messages. Also, the reject of a frame doesn't mean an alarming error. This patch demotes the log message from error to info. --- gst/vaapi/gstvaapidecode.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gst/vaapi/gstvaapidecode.c b/gst/vaapi/gstvaapidecode.c index 685da6bbb0..276a050297 100644 --- a/gst/vaapi/gstvaapidecode.c +++ b/gst/vaapi/gstvaapidecode.c @@ -319,9 +319,8 @@ error_get_meta: } error_commit_buffer: { - if (ret != GST_FLOW_FLUSHING) - GST_ERROR ("video sink rejected the video buffer (error: %s [%d])", - gst_flow_get_name (ret), ret); + GST_INFO_OBJECT (decode, "downstream element rejected the frame (%s [%d])", + gst_flow_get_name (ret), ret); gst_video_codec_frame_unref (out_frame); return ret; } @@ -407,10 +406,7 @@ gst_vaapidecode_handle_frame (GstVideoDecoder * vdec, /* Note that gst_vaapi_decoder_decode cannot return success without completing the decode and pushing all decoded frames into the output queue */ - ret = gst_vaapidecode_push_all_decoded_frames (decode); - if (ret != GST_FLOW_OK && ret != GST_FLOW_FLUSHING) - GST_ERROR ("push loop error after decoding %d", ret); - return ret; + return gst_vaapidecode_push_all_decoded_frames (decode); /* ERRORS */ error_push_all_decoded_frames: