From de69fc148db38e87b16b810cc159e7e730100553 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Fri, 23 Nov 2018 13:25:43 +0200 Subject: [PATCH] convertframe: Error out directly in the sync variant if the state change to PAUSED failed --- gst-libs/gst/video/convertframe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/video/convertframe.c b/gst-libs/gst/video/convertframe.c index f02f05b85b..4b69fa4457 100644 --- a/gst-libs/gst/video/convertframe.c +++ b/gst-libs/gst/video/convertframe.c @@ -340,7 +340,9 @@ gst_video_convert_sample (GstSample * sample, const GstCaps * to_caps, * appsrc, this should preroll the converted buffer in appsink */ GST_DEBUG ("running conversion pipeline to caps %" GST_PTR_FORMAT, to_caps_copy); - gst_element_set_state (pipeline, GST_STATE_PAUSED); + if (gst_element_set_state (pipeline, + GST_STATE_PAUSED) == GST_STATE_CHANGE_FAILURE) + goto state_change_failed; /* feed buffer in appsrc */ GST_DEBUG ("feeding buffer %p, size %" G_GSIZE_FORMAT ", caps %" @@ -403,6 +405,7 @@ gst_video_convert_sample (GstSample * sample, const GstCaps * to_caps, /* ERRORS */ no_pipeline: +state_change_failed: { gst_caps_unref (to_caps_copy);