From de19e8a84fb2fed99b14ab5310053bf6cdf24818 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Sat, 17 Jul 2021 20:49:15 +0200 Subject: [PATCH] va: vp9dec: Minor cleanups. Added a comment with a future to-do, enhanced another comment and fixed a typo in an error log message. Part-of: --- sys/va/gstvavp9dec.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sys/va/gstvavp9dec.c b/sys/va/gstvavp9dec.c index 0340e1e4de..33631a84f3 100644 --- a/sys/va/gstvavp9dec.c +++ b/sys/va/gstvavp9dec.c @@ -200,9 +200,13 @@ _check_resolution_change (GstVaVp9Dec * self, GstVp9Picture * picture) self->need_negotiation = TRUE; if (!gst_video_decoder_negotiate (GST_VIDEO_DECODER (self))) { - GST_ERROR_OBJECT (self, "Resolution changes, but failed to" + GST_ERROR_OBJECT (self, "Resolution changed, but failed to" " negotiate with downstream"); return FALSE; + + /* @TODO: if negotiation fails, decoder should resize output + * frame. For that we would need an auxiliar allocator, and + * later use GstVaFilter or GstVideoConverter. */ } } @@ -544,9 +548,9 @@ gst_va_vp9_dec_negotiate (GstVideoDecoder * decoder) self->need_negotiation = FALSE; need_open = TRUE; - /* The driver for VP9 should have the ability to handle the dynamical - resolution changes. So if only the resolution changes, we should not - re-create the config and context. */ + /* VP9 profile entry should have the ability to handle dynamical + * resolution changes. If only the resolution changes, we should not + * re-create the config and context. */ if (gst_va_decoder_is_open (base->decoder)) { VAProfile cur_profile; guint cur_rtformat;