From db765a5fb886d99f42c313594f3e0147d4d8d4e6 Mon Sep 17 00:00:00 2001 From: Jason Litzinger Date: Wed, 22 Apr 2015 12:03:33 -0600 Subject: [PATCH] gstinfo: fix infinite loop in gst_debug_unset_threshold_for_name() Ensure iterator is advanced. The current list iteration code only advances the iterator (walk) if a match is found, which results in an infinite loop when more than one entry exists in the list. https://bugzilla.gnome.org/show_bug.cgi?id=748321 --- gst/gstinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst/gstinfo.c b/gst/gstinfo.c index 3f566866aa..4e1c2968ef 100644 --- a/gst/gstinfo.c +++ b/gst/gstinfo.c @@ -1507,6 +1507,8 @@ gst_debug_unset_threshold_for_name (const gchar * name) g_slice_free (LevelNameEntry, entry); g_slist_free_1 (walk); walk = __level_name; + } else { + walk = g_slist_next (walk); } } g_mutex_unlock (&__level_name_mutex);