From da3886acacd0c7b6fe8664bec599b1d34732df6b Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Sat, 6 Feb 2021 03:58:54 +1100 Subject: [PATCH] pad: Improve the documentation for GstPadProbeReturn. Explain that GST_PAD_PROBE_PASS will pass data even if there is another pad probe that says to block, and that GST_PAD_PROBE_REMOVE passes data and potentially unblocks the pad. Part-of: --- gst/gstpad.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gst/gstpad.h b/gst/gstpad.h index 8cc896dec7..c89be30508 100644 --- a/gst/gstpad.h +++ b/gst/gstpad.h @@ -548,9 +548,12 @@ typedef enum * the data item is not passed upstream. In both cases, no other probes * are called for this item and %GST_FLOW_OK or %TRUE is returned to the * caller. - * @GST_PAD_PROBE_REMOVE: remove this probe. + * @GST_PAD_PROBE_REMOVE: remove this probe, passing the data. For blocking probes + * this will cause data flow to unblock, unless there are also other + * blocking probes installed. * @GST_PAD_PROBE_PASS: pass the data item in the block probe and block on the - * next item. + * next item. Note, that if there are multiple pad probes installed and + * any probe returns PASS, the data will be passed. * @GST_PAD_PROBE_HANDLED: Data has been handled in the probe and will not be * forwarded further. For events and buffers this is the same behaviour as * %GST_PAD_PROBE_DROP (except that in this case you need to unref the buffer