From d8dabf142f5c9ebd2f7cfbb38a07442d208af06d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 17 Apr 2024 16:50:30 +0300 Subject: [PATCH] rtpbin: Constify function parameters and use correct types Previously these parameters were randomly changed in the body of the function to avoid having to declare a new variable, which made the code very hard to follow. By marking them as const this won't be possible anymore in the future. Also the RTP clock-base (RTP time from RTSP RTP-Info) is an unsigned 64 bit integer as it's an extended RTP timestamp. Part-of: --- subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c index e521a4122d..10fd9ad037 100644 --- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c +++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c @@ -1468,10 +1468,11 @@ gst_rtp_bin_send_sync_event (GstRtpBinStream * stream) * * Must be called with GST_RTP_BIN_LOCK */ static void -gst_rtp_bin_associate (GstRtpBin * bin, GstRtpBinStream * stream, guint8 len, - const guint8 * data, guint64 ntpnstime, guint64 extrtptime, - guint64 base_rtptime, guint64 base_time, guint clock_rate, - gint64 rtp_clock_base) +gst_rtp_bin_associate (GstRtpBin * bin, GstRtpBinStream * stream, + const guint8 len, const guint8 * data, const guint64 ntpnstime, + const guint64 extrtptime, const guint64 base_rtptime, + const guint64 base_time, const guint clock_rate, + const guint64 rtp_clock_base) { /* Don't do any stream offsetting in RFC7273 sync mode. Everything is * handled inside rtpjitterbuffer for this case. */