From d64761af50b49ac9720499b0c0f968a2a942bcf0 Mon Sep 17 00:00:00 2001 From: Michael Smith Date: Mon, 6 Mar 2006 16:24:53 +0000 Subject: [PATCH] gst/: Don't leak PyObjects wrapping GValues when indexing into a Original commit message from CVS: * gst/gststructure.override: * gst/gsttaglist.override: Don't leak PyObjects wrapping GValues when indexing into a GStStructure. Also fix a copy/paste identical bug in taglists. --- ChangeLog | 7 +++++++ gst/gststructure.override | 2 -- gst/gsttaglist.override | 2 -- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 54bdc12b45..2a87897244 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2006-03-06 Michael Smith + + * gst/gststructure.override: + * gst/gsttaglist.override: + Don't leak PyObjects wrapping GValues when indexing into a + GStStructure. Also fix a copy/paste identical bug in taglists. + 2006-03-02 Edward Hervey * gst/pygstminiobject.h: diff --git a/gst/gststructure.override b/gst/gststructure.override index 4df4e82f8a..68bedbea51 100644 --- a/gst/gststructure.override +++ b/gst/gststructure.override @@ -193,8 +193,6 @@ _wrap_gst_structure_subscript(PyGObject *self, PyObject *py_key) PyErr_SetString(PyExc_KeyError, field); } - if (v != NULL) - Py_INCREF(v); return v; } diff --git a/gst/gsttaglist.override b/gst/gsttaglist.override index 85ae61ac2b..2ce31cef53 100644 --- a/gst/gsttaglist.override +++ b/gst/gsttaglist.override @@ -84,8 +84,6 @@ _wrap_gst_tag_list_subscript(PyGObject *self, PyObject *py_key) PyErr_SetString(PyExc_KeyError, field); } - if (v != NULL) - Py_INCREF(v); return v; }