mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-23 10:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2decoder: Convert request pool to GstQueueArray

Browse source 
The decoder is not being access from multiple threads, instead it is
always protected by the streaming lock. For this reason, a
GstAtomicQueue for the request pool is overkill and may even introduce
unneeded overhead. Use a GstQueueArray in replacement, the
GstQueueArray is a good fit since the number of item is predictable and
unlikely to vary at run-time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>
This commit is contained in:
Nicolas Dufresne 2020-07-01 12:23:49 -04:00
parent a2eb1b57ff
commit d5a205cff4
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sys/v4l2codecs/gstv4l2decoder.c
View file

@ -33,6 +33,8 @@
#include <sys/types.h> #include <sys/types.h>
#include <unistd.h> #include <unistd.h>
#include <gst/base/base.h>
GST_DEBUG_CATEGORY (v4l2_decoder_debug); GST_DEBUG_CATEGORY (v4l2_decoder_debug);
#define GST_CAT_DEFAULT v4l2_decoder_debug #define GST_CAT_DEFAULT v4l2_decoder_debug
@ -60,7 +62,7 @@ struct _GstV4l2Decoder
gboolean opened; gboolean opened;
gint media_fd; gint media_fd;
gint video_fd; gint video_fd;
GstAtomicQueue *request_pool; GstQueueArray *request_pool;
enum v4l2_buf_type src_buf_type; enum v4l2_buf_type src_buf_type;
enum v4l2_buf_type sink_buf_type; enum v4l2_buf_type sink_buf_type;
@ -93,7 +95,7 @@ gst_v4l2_decoder_finalize (GObject * obj)
g_free (self->media_device); g_free (self->media_device);
g_free (self->video_device); g_free (self->video_device);
gst_atomic_queue_unref (self->request_pool); gst_queue_array_free (self->request_pool);
G_OBJECT_CLASS (gst_v4l2_decoder_parent_class)->finalize (obj); G_OBJECT_CLASS (gst_v4l2_decoder_parent_class)->finalize (obj);
} }
@ -101,7 +103,7 @@ gst_v4l2_decoder_finalize (GObject * obj)
static void static void
gst_v4l2_decoder_init (GstV4l2Decoder * self) gst_v4l2_decoder_init (GstV4l2Decoder * self)
{ {
self->request_pool = gst_atomic_queue_new (16); self->request_pool = gst_queue_array_new (16);
} }
static void static void
@ -188,7 +190,7 @@ gst_v4l2_decoder_close (GstV4l2Decoder * self)
{ {
GstV4l2Request *request; GstV4l2Request *request;
while ((request = gst_atomic_queue_pop (self->request_pool))) while ((request = gst_queue_array_pop_head (self->request_pool)))
gst_v4l2_request_free (request); gst_v4l2_request_free (request);
if (self->media_fd) if (self->media_fd)
@ -786,7 +788,7 @@ gst_v4l2_decoder_register (GstPlugin * plugin,
GstV4l2Request * GstV4l2Request *
gst_v4l2_decoder_alloc_request (GstV4l2Decoder * self) gst_v4l2_decoder_alloc_request (GstV4l2Decoder * self)
{ {
GstV4l2Request *request = gst_atomic_queue_pop (self->request_pool); GstV4l2Request *request = gst_queue_array_pop_head (self->request_pool);
gint ret; gint ret;
if (!request) { if (!request) {
@ -844,7 +846,7 @@ gst_v4l2_request_free (GstV4l2Request * request)
return; return;
} }
gst_atomic_queue_push (decoder->request_pool, request); gst_queue_array_push_tail (decoder->request_pool, request);
g_object_unref (decoder); g_object_unref (decoder);
} }