mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-30 13:41:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

uridownloader: Fix potential deadlock

Browse source 
The streaming thread might use our lock, so shutting
down the element while holding that lock calls for problems.
This commit is contained in:
Sebastian Dröge 2014-02-12 18:06:43 +01:00
parent 8cd6208b7d
commit d436844434
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst-libs/gst/uridownloader/gsturidownloader.c
View file

@ -461,9 +461,11 @@ quit:
gst_bus_set_sync_handler (downloader->priv->bus, NULL, NULL, NULL); gst_bus_set_sync_handler (downloader->priv->bus, NULL, NULL, NULL);
/* set the element state to NULL */ /* set the element state to NULL */
GST_OBJECT_UNLOCK (downloader);
gst_bus_set_flushing (downloader->priv->bus, TRUE); gst_bus_set_flushing (downloader->priv->bus, TRUE);
gst_element_set_state (urisrc, GST_STATE_NULL); gst_element_set_state (urisrc, GST_STATE_NULL);
gst_element_get_state (urisrc, NULL, NULL, GST_CLOCK_TIME_NONE); gst_element_get_state (urisrc, NULL, NULL, GST_CLOCK_TIME_NONE);
GST_OBJECT_LOCK (downloader);
gst_element_set_bus (urisrc, NULL); gst_element_set_bus (urisrc, NULL);
/* unlink the source element from the internal pad */ /* unlink the source element from the internal pad */