From d3211824bde60a008ed13af2b2752b280b281bf5 Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Fri, 28 Apr 2006 20:55:33 +0000 Subject: [PATCH] libs/gst/base/gstcollectpads.c: fix changelog entry about last collectpads change, add notes about proper fix Original commit message from CVS: * libs/gst/base/gstcollectpads.c: (gst_collect_pads_event): fix changelog entry about last collectpads change, add notes about proper fix --- ChangeLog | 6 ++++++ libs/gst/base/gstcollectpads.c | 9 +++++++++ 2 files changed, 15 insertions(+) diff --git a/ChangeLog b/ChangeLog index 1bd46da223..8e6f2def75 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-04-28 Stefan Kost + + * libs/gst/base/gstcollectpads.c: (gst_collect_pads_event): + fix changelog entry about last collectpads change, + add notes about proper fix + 2006-04-28 Stefan Kost * gst/gst.c: diff --git a/libs/gst/base/gstcollectpads.c b/libs/gst/base/gstcollectpads.c index 3fe515c4f5..ff40dbbd87 100644 --- a/libs/gst/base/gstcollectpads.c +++ b/libs/gst/base/gstcollectpads.c @@ -743,6 +743,15 @@ gst_collect_pads_event (GstPad * pad, GstEvent * event) /* forward to src-pad, sink-elements like to get the event */ gst_pad_event_default (pad, event); + /* FIXME: collect-pads based elements need to create their own newsegment + event (and only one really) + (a) make the segment part of the GstCollectData structure of each pad, + so you can just check that once you have a buffer queued on that pad, + (b) you can override a pad's event function with your own, + catch the newsegment event and then pass it on to the original + gstcollectpads event function + (that's what avimux does for something IIRC) + */ return TRUE; } default: