From d25908cf81798b9d510a43160b7fc9dcd3b21397 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Fri, 20 May 2011 15:25:08 -0300 Subject: [PATCH] camerabin2: Do not segfault on null locations Prevent capture from starting when saving location is set to NULL --- gst/camerabin2/gstcamerabin2.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gst/camerabin2/gstcamerabin2.c b/gst/camerabin2/gstcamerabin2.c index deaa8807a0..0c8c4dafc6 100644 --- a/gst/camerabin2/gstcamerabin2.c +++ b/gst/camerabin2/gstcamerabin2.c @@ -212,6 +212,16 @@ gst_camera_bin_start_capture (GstCameraBin * camerabin) const GstTagList *taglist; GST_DEBUG_OBJECT (camerabin, "Received start-capture"); + + /* check that we have a valid location */ + if ((camerabin->mode == MODE_VIDEO && camerabin->video_location == NULL) + || (camerabin->mode == MODE_IMAGE && camerabin->image_location == NULL)) { + GST_ELEMENT_ERROR (camerabin, RESOURCE, OPEN_WRITE, + (_("File location is set to NULL, please set it to a valid filename")), + (NULL)); + return; + } + GST_CAMERA_BIN_PROCESSING_INC (camerabin); if (camerabin->mode == MODE_VIDEO && camerabin->audio_src) {