diff --git a/gst-libs/gst/tag/id3v2.c b/gst-libs/gst/tag/id3v2.c index 4579d25d70..54f38fca11 100644 --- a/gst-libs/gst/tag/id3v2.c +++ b/gst-libs/gst/tag/id3v2.c @@ -236,10 +236,16 @@ gst_tag_list_from_id3v2_tag (GstBuffer * buffer) work.hdr.size = read_size; work.hdr.flags = flags; work.hdr.frame_data = info.data + ID3V2_HDR_SIZE; - if (flags & ID3V2_HDR_FLAG_FOOTER) + + if (flags & ID3V2_HDR_FLAG_FOOTER) { + if (read_size < ID3V2_HDR_SIZE + 10) + goto not_enough_data; /* Invalid frame size */ work.hdr.frame_data_size = read_size - ID3V2_HDR_SIZE - 10; - else + } else { + if (read_size < ID3V2_HDR_SIZE) + goto not_enough_data; /* Invalid frame size */ work.hdr.frame_data_size = read_size - ID3V2_HDR_SIZE; + } /* in v2.3 the frame sizes are not syncsafe, so the entire tag had to be * unsynced. In v2.4 the frame sizes are syncsafe so it's just the frame