From d16367f0465fc446570fab59cbf96806a4cc06bb Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Wed, 20 May 2020 07:35:28 -0400 Subject: [PATCH] v4l2codecs: h264: Add missing break There was a missing break for the 4:4:4 case which would break the sizeimage calculation. We don't currently have hardware that supports 4:4:4, so this code wasn't tested. This was detected by Coverity. CID 1463592 1463591 Part-of: --- sys/v4l2codecs/gstv4l2codech264dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/v4l2codecs/gstv4l2codech264dec.c b/sys/v4l2codecs/gstv4l2codech264dec.c index 29f96d4f83..0fa96dd787 100644 --- a/sys/v4l2codecs/gstv4l2codech264dec.c +++ b/sys/v4l2codecs/gstv4l2codech264dec.c @@ -211,6 +211,7 @@ get_pixel_bitdepth (GstV4l2CodecH264Dec * self) case 3: /* 4:4:4 */ depth = 3 * self->bitdepth; + break; default: GST_WARNING_OBJECT (self, "Unsupported chroma format %i", self->chroma_format_idc);