From d09605a3ffc9c9d8309aeebe5bb1d47a9b1b2600 Mon Sep 17 00:00:00 2001 From: Nirbheek Chauhan Date: Tue, 10 Dec 2024 13:12:18 +0530 Subject: [PATCH] vtenc: Fix authors of encoder features Part-of: --- .../docs/plugins/gst_plugins_cache.json | 12 ++++----- .../gst-plugins-bad/sys/applemedia/vtenc.c | 27 +++++++++++++------ .../gst-plugins-bad/sys/applemedia/vtenc.h | 7 ++--- 3 files changed, 29 insertions(+), 17 deletions(-) diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json index af0d32e026..cb650a761c 100644 --- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json +++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json @@ -4788,7 +4788,7 @@ "rank": "primary" }, "vtenc_h265": { - "author": "Ole André Vadla Ravnås , Dominik Röttsches ", + "author": "Piotr Brzeziński ", "description": "H.265/HEVC encoder", "hierarchy": [ "vtenc_h265", @@ -4924,7 +4924,7 @@ "rank": "primary" }, "vtenc_h265_hw": { - "author": "Ole André Vadla Ravnås , Dominik Röttsches ", + "author": "Piotr Brzeziński ", "description": "H.265/HEVC (HW only) encoder", "hierarchy": [ "vtenc_h265_hw", @@ -5060,7 +5060,7 @@ "rank": "primary" }, "vtenc_h265a": { - "author": "Ole André Vadla Ravnås , Dominik Röttsches ", + "author": "Piotr Brzeziński ", "description": "H.265/HEVC with alpha encoder", "hierarchy": [ "vtenc_h265a", @@ -5196,7 +5196,7 @@ "rank": "primary" }, "vtenc_h265a_hw": { - "author": "Ole André Vadla Ravnås , Dominik Röttsches ", + "author": "Piotr Brzeziński ", "description": "H.265/HEVC with alpha (HW only) encoder", "hierarchy": [ "vtenc_h265a_hw", @@ -5332,7 +5332,7 @@ "rank": "primary" }, "vtenc_prores": { - "author": "Ole André Vadla Ravnås , Dominik Röttsches ", + "author": "Nirbheek Chauhan ", "description": "Apple ProRes encoder", "hierarchy": [ "vtenc_prores", @@ -254320,4 +254320,4 @@ "tracers": {}, "url": "Unknown package origin" } -} +} \ No newline at end of file diff --git a/subprojects/gst-plugins-bad/sys/applemedia/vtenc.c b/subprojects/gst-plugins-bad/sys/applemedia/vtenc.c index ae753fa45a..1efa27ad6c 100644 --- a/subprojects/gst-plugins-bad/sys/applemedia/vtenc.c +++ b/subprojects/gst-plugins-bad/sys/applemedia/vtenc.c @@ -309,8 +309,7 @@ gst_vtenc_base_init (GstVTEncClass * klass) description = g_strdup_printf ("%s encoder", codec_details->name); gst_element_class_set_metadata (element_class, longname, - "Codec/Encoder/Video/Hardware", description, - "Ole André Vadla Ravnås , Dominik Röttsches "); + "Codec/Encoder/Video/Hardware", description, codec_details->authors); g_free (longname); g_free (description); @@ -2551,7 +2550,7 @@ gst_vtenc_register (GstPlugin * plugin, 0, (GInstanceInitFunc) gst_vtenc_init, }; - gchar *type_name; + char *type_name; GType type; gboolean result; @@ -2571,18 +2570,30 @@ gst_vtenc_register (GstPlugin * plugin, } static const GstVTEncoderDetails gst_vtenc_codecs[] = { - {"H.264", "h264", "video/x-h264", kCMVideoCodecType_H264, FALSE}, - {"H.265/HEVC", "h265", "video/x-h265", kCMVideoCodecType_HEVC, FALSE}, + {"H.264", "h264", "video/x-h264", + "Ole André Vadla Ravnås , " + "Dominik Röttsches ", + kCMVideoCodecType_H264, FALSE}, + {"H.265/HEVC", "h265", "video/x-h265", + "Piotr Brzeziński ", + kCMVideoCodecType_HEVC, FALSE}, {"H.265/HEVC with alpha", "h265a", "video/x-h265", + "Piotr Brzeziński ", kCMVideoCodecType_HEVCWithAlpha, FALSE}, #ifndef HAVE_IOS - {"H.264 (HW only)", "h264_hw", "video/x-h264", kCMVideoCodecType_H264, TRUE}, - {"H.265/HEVC (HW only)", "h265_hw", "video/x-h265", kCMVideoCodecType_HEVC, - TRUE}, + {"H.264 (HW only)", "h264_hw", "video/x-h264", + "Ole André Vadla Ravnås , " + "Dominik Röttsches ", + kCMVideoCodecType_H264, TRUE}, + {"H.265/HEVC (HW only)", "h265_hw", "video/x-h265", + "Piotr Brzeziński ", + kCMVideoCodecType_HEVC, TRUE}, {"H.265/HEVC with alpha (HW only)", "h265a_hw", "video/x-h265", + "Piotr Brzeziński ", kCMVideoCodecType_HEVCWithAlpha, TRUE}, #endif {"Apple ProRes", "prores", "video/x-prores", + "Nirbheek Chauhan ", GST_kCMVideoCodecType_Some_AppleProRes, FALSE}, }; diff --git a/subprojects/gst-plugins-bad/sys/applemedia/vtenc.h b/subprojects/gst-plugins-bad/sys/applemedia/vtenc.h index 58e3bc9c4c..761d940635 100644 --- a/subprojects/gst-plugins-bad/sys/applemedia/vtenc.h +++ b/subprojects/gst-plugins-bad/sys/applemedia/vtenc.h @@ -59,9 +59,10 @@ typedef struct _GstVTEncoderDetails GstVTEncoderDetails; struct _GstVTEncoderDetails { - const gchar * name; - const gchar * element_name; - const gchar * mimetype; + const char * name; + const char * element_name; + const char * mimetype; + const char * authors; CMVideoCodecType format_id; gboolean require_hardware; };