From d06187c2184be6a507f39ccf2da7311dfb62c11f Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Fri, 8 Apr 2022 13:44:53 +1000 Subject: [PATCH] gst: remove custom logger for critical/warnings/fatals It's not really needed anymore (only calls out to g_log_default_handler() and interferes with applications using g_log_set_default_handler(). Part-of: --- subprojects/gstreamer/gst/gst.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/subprojects/gstreamer/gst/gst.c b/subprojects/gstreamer/gst/gst.c index c168d4de57..9d45442ab1 100644 --- a/subprojects/gstreamer/gst/gst.c +++ b/subprojects/gstreamer/gst/gst.c @@ -168,16 +168,6 @@ static gboolean parse_goption_arg (const gchar * s_opt, GSList *_priv_gst_preload_plugins = NULL; -static void -debug_log_handler (const gchar * log_domain, - GLogLevelFlags log_level, const gchar * message, gpointer user_data) -{ - g_log_default_handler (log_domain, log_level, message, user_data); - /* FIXME: do we still need this ? fatal errors these days are all - * other than core errors */ - /* g_on_error_query (NULL); */ -} - enum { ARG_VERSION = 1, @@ -670,17 +660,11 @@ static gboolean init_post (GOptionContext * context, GOptionGroup * group, gpointer data, GError ** error) { - GLogLevelFlags llf; - if (gst_initialized) { GST_DEBUG ("already initialized"); return TRUE; } - llf = G_LOG_LEVEL_CRITICAL | G_LOG_LEVEL_ERROR | G_LOG_FLAG_FATAL; - /* TODO: should we also set up a handler for the other gst libs/domains? */ - g_log_set_handler (G_LOG_DOMAIN, llf, debug_log_handler, NULL); - _priv_gst_mini_object_initialize (); _priv_gst_quarks_initialize (); _priv_gst_allocator_initialize ();