mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-30 13:41:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

va: allocator: Disable derived for i965 if YUV and writing.

Browse source 
The problem is for uploading YUV frames using derived images, is that
derived images imply tiling, so frames are wrongly uploaded.

Though derived for reading might work we cannot know the Intel graphics
generation to validate the caching. Overall, it's safer to disable derived
images for i965.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2127>
This commit is contained in:
Víctor Manuel Jáquez Leal 2021-04-22 17:08:13 +02:00
parent 2b0fa73c10
commit ced093c738
1 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
sys/va/gstvaallocator.c
View file

@ -1256,11 +1256,25 @@ _va_map_unlocked (GstVaMemory * mem, GstMapFlags flags)
goto success; goto success;
} }
/* On Gen7-Gen9 Intel graphics the memory is mappable but not switch (gst_va_display_get_implementation (display)) {
* cached, so normal memcpy() access is very slow to read, but it's case GST_VA_IMPLEMENTATION_INTEL_IHD:
* ok for writing. So let's assume that users won't prefer /* On Gen7+ Intel graphics the memory is mappable but not
* direct-mapped memory if they request read access. */ * cached, so normal memcpy() access is very slow to read, but
use_derived = va_allocator->use_derived && !(flags & GST_MAP_READ); * it's ok for writing. So let's assume that users won't prefer
* direct-mapped memory if they request read access. */
use_derived = va_allocator->use_derived && !(flags & GST_MAP_READ);
break;
case GST_VA_IMPLEMENTATION_INTEL_I965:
/* YUV derived images are tiled, so writing them is also
* problematic */
use_derived = va_allocator->use_derived && !((flags & GST_MAP_READ)
|| ((flags & GST_MAP_WRITE)
&& GST_VIDEO_INFO_IS_YUV (&va_allocator->derived_info)));
break;
default:
use_derived = va_allocator->use_derived;
break;
}
if (use_derived) if (use_derived)
info = &va_allocator->derived_info; info = &va_allocator->derived_info;
else else