From ce2c8b6706e0662bbd197f40fea8281746694145 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 14 May 2008 21:02:19 +0000 Subject: [PATCH] gst/rtpmanager/gstrtpjitterbuffer.c: Simply drop bad RTP packets with a warning instead of just posting an error and ... Original commit message from CVS: * gst/rtpmanager/gstrtpjitterbuffer.c: (gst_rtp_jitter_buffer_chain): Simply drop bad RTP packets with a warning instead of just posting an error and stopping. This is a perfectly recoverable event and we don't force people to use an rtpbin to filter out bad packets first. --- ChangeLog | 8 ++++++++ gst/rtpmanager/gstrtpjitterbuffer.c | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3546af549c..18247f580a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-05-14 Wim Taymans + + * gst/rtpmanager/gstrtpjitterbuffer.c: + (gst_rtp_jitter_buffer_chain): + Simply drop bad RTP packets with a warning instead of just posting an + error and stopping. This is a perfectly recoverable event and we don't + force people to use an rtpbin to filter out bad packets first. + 2008-05-14 Wim Taymans * gst/mpeg4videoparse/mpeg4videoparse.c: (gst_mpeg4vparse_init): diff --git a/gst/rtpmanager/gstrtpjitterbuffer.c b/gst/rtpmanager/gstrtpjitterbuffer.c index c62a6c505c..46439dc1b9 100644 --- a/gst/rtpmanager/gstrtpjitterbuffer.c +++ b/gst/rtpmanager/gstrtpjitterbuffer.c @@ -945,12 +945,12 @@ finished: /* ERRORS */ invalid_buffer: { - /* this is fatal and should be filtered earlier */ - GST_ELEMENT_ERROR (jitterbuffer, STREAM, DECODE, (NULL), - ("Received invalid RTP payload")); + /* this is not fatal but should be filtered earlier */ + GST_ELEMENT_WARNING (jitterbuffer, STREAM, DECODE, (NULL), + ("Received invalid RTP payload, dropping")); gst_buffer_unref (buffer); gst_object_unref (jitterbuffer); - return GST_FLOW_ERROR; + return GST_FLOW_OK; } not_negotiated: {