From cbf204e4ae04cb6d03003203f036c3e43d1c6550 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Mon, 28 Oct 2024 10:41:08 -0300 Subject: [PATCH] multiqueue: Do not unref the query we get in pad->query We do not own any ref to queries when running them. If we end up processing the query from the streaming thread, it means that it was a serialized query, and the query is being waited to be processed on the sinkpad streaming thread, thread which owns the reference. Part-of: --- subprojects/gstreamer/plugins/elements/gstmultiqueue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/subprojects/gstreamer/plugins/elements/gstmultiqueue.c b/subprojects/gstreamer/plugins/elements/gstmultiqueue.c index ea20f8b294..1f2bf825ff 100644 --- a/subprojects/gstreamer/plugins/elements/gstmultiqueue.c +++ b/subprojects/gstreamer/plugins/elements/gstmultiqueue.c @@ -2078,7 +2078,6 @@ gst_single_queue_push_one (GstMultiQueue * mq, GstSingleQueue * sq, if (G_UNLIKELY (*allow_drop)) { GST_DEBUG_ID (sq->debug_id, "Dropping EOS query %p", query); - gst_query_unref (query); res = FALSE; } else { res = gst_pad_peer_query (srcpad, query);