From cbc0a2f056aced60c7e8c8be861a18e0743f5af2 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Thu, 28 Jul 2011 18:21:04 -0400 Subject: [PATCH] mpegtsbase: Prevent stack gardening by using the right type stream_type is stored as guint inside the GstStructure but was retreived using valist with a pointer to guint16. This would cause stack gardening when code is compiled without optimisation (e.g. in -O0 the compiler wont pad the stack to optimise out required mask). https://bugzilla.gnome.org/show_bug.cgi?id=655540 --- gst/mpegtsdemux/mpegtsbase.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/mpegtsdemux/mpegtsbase.c b/gst/mpegtsdemux/mpegtsbase.c index ac4b6157a0..e3be7c84b6 100644 --- a/gst/mpegtsdemux/mpegtsbase.c +++ b/gst/mpegtsdemux/mpegtsbase.c @@ -615,7 +615,7 @@ mpegts_base_activate_program (MpegTSBase * base, MpegTSBaseProgram * program, guint i, nbstreams; guint pcr_pid; guint pid; - guint16 stream_type; + guint stream_type; GstStructure *stream; const GValue *new_streams; const GValue *value;