From c90af726ab305f12d8803046fb56786f34a3ddea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 14 Sep 2020 10:15:35 +0300 Subject: [PATCH] rtpmp4gdepay: Allow lower-case "aac-hbr" instead of correct "AAC-hbr" Various live555 based products are using the wrong "mode" string or seem to assume case-insensitive matching, which is wrong. Examples for this are the Yuan SC6C0N1 mini and the Kiloview E2. Part-of: --- docs/gst_plugins_cache.json | 2 +- gst/rtp/gstrtpmp4gdepay.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/gst_plugins_cache.json b/docs/gst_plugins_cache.json index 2f1bfeea10..56b7a8cc84 100644 --- a/docs/gst_plugins_cache.json +++ b/docs/gst_plugins_cache.json @@ -15369,7 +15369,7 @@ "long-name": "RTP MPEG4 ES depayloader", "pad-templates": { "sink": { - "caps": "application/x-rtp:\n media: { (string)video, (string)audio, (string)application }\n clock-rate: [ 1, 2147483647 ]\n encoding-name: MPEG4-GENERIC\n mode: { (string)generic, (string)CELP-cbr, (string)CELP-vbr, (string)AAC-lbr, (string)AAC-hbr }\n", + "caps": "application/x-rtp:\n media: { (string)video, (string)audio, (string)application }\n clock-rate: [ 1, 2147483647 ]\n encoding-name: MPEG4-GENERIC\n mode: { (string)generic, (string)CELP-cbr, (string)CELP-vbr, (string)AAC-lbr, (string)AAC-hbr, (string)aac-hbr }\n", "direction": "sink", "presence": "always" }, diff --git a/gst/rtp/gstrtpmp4gdepay.c b/gst/rtp/gstrtpmp4gdepay.c index 5c4b454080..a734be065f 100644 --- a/gst/rtp/gstrtpmp4gdepay.c +++ b/gst/rtp/gstrtpmp4gdepay.c @@ -53,7 +53,7 @@ GST_STATIC_PAD_TEMPLATE ("sink", /* "streamtype = (string) { \"4\", \"5\" }, " Not set by Wowza 4 = video, 5 = audio */ /* "profile-level-id = (string) [1,MAX], " */ /* "config = (string) [1,MAX]" */ - "mode = (string) { \"generic\", \"CELP-cbr\", \"CELP-vbr\", \"AAC-lbr\", \"AAC-hbr\" } " + "mode = (string) { \"generic\", \"CELP-cbr\", \"CELP-vbr\", \"AAC-lbr\", \"AAC-hbr\", \"aac-hbr\" } " /* Optional general parameters */ /* "objecttype = (string) [1,MAX], " */ /* "constantsize = (string) [1,MAX], " *//* constant size of each AU */