From c8e6b90f4b8025932b5d7e1f67842fcf09d9bcff Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Fri, 27 Mar 2015 15:59:42 +0100 Subject: [PATCH] validate: pad-monitor: fix caps leak Don't create othercaps when early returning. --- validate/gst/validate/gst-validate-pad-monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/validate/gst/validate/gst-validate-pad-monitor.c b/validate/gst/validate/gst-validate-pad-monitor.c index 440a13b35b..ad6ce35e70 100644 --- a/validate/gst/validate/gst-validate-pad-monitor.c +++ b/validate/gst/validate/gst-validate-pad-monitor.c @@ -666,7 +666,7 @@ static GstCaps * gst_validate_pad_monitor_transform_caps (GstValidatePadMonitor * monitor, GstCaps * caps) { - GstCaps *othercaps = gst_caps_new_empty (); + GstCaps *othercaps; GstCaps *new_caps; GstIterator *iter; gboolean done; @@ -678,6 +678,8 @@ gst_validate_pad_monitor_transform_caps (GstValidatePadMonitor * monitor, if (caps == NULL) return NULL; + othercaps = gst_caps_new_empty (); + iter = gst_pad_iterate_internal_links (GST_VALIDATE_PAD_MONITOR_GET_PAD (monitor));