From c6e9ce64ae2251be28a135bffbd6b57751779b0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 18 Apr 2011 10:04:24 +0200 Subject: [PATCH] pad: Remove unnecessary FIXME Resetting the result is not necessary when resyncing because pads that previously got the event will be skipped and we need to consider the results of the previous pushes. --- gst/gstpad.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/gstpad.c b/gst/gstpad.c index 382a6c5232..bdc3f69dbe 100644 --- a/gst/gstpad.c +++ b/gst/gstpad.c @@ -2961,8 +2961,9 @@ gst_pad_event_default_dispatch (GstPad * pad, GstEvent * event) gst_object_unref (item); break; case GST_ITERATOR_RESYNC: - /* FIXME, if we want to reset the result value we need to remember which - * pads pushed with which result */ + /* We don't reset the result here because we don't push the event + * again on pads that got the event already and because we need + * to consider the result of the previous pushes */ gst_iterator_resync (iter); break; case GST_ITERATOR_ERROR: