From c673c09e4f57148c976599438ef95778a851b96c Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Thu, 5 Mar 2009 10:51:25 +0200 Subject: [PATCH] v4l: add a fixme for broken code, that someone who has a v4l tuner device should fix --- sys/v4l/v4l_calls.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/v4l/v4l_calls.c b/sys/v4l/v4l_calls.c index 0baf5ade1c..0a01265963 100644 --- a/sys/v4l/v4l_calls.c +++ b/sys/v4l/v4l_calls.c @@ -330,6 +330,11 @@ gst_v4l_get_chan_names (GstV4lElement * v4lelement) continue; /* not this one */ } } + /* FIXME: in the case of n >= vchan.tuners the code below accesses + * uninitialised fields in vtun + * Not sure if the codeblock below should go into the else above, but + * then setting vtun.tuner=0 is a bit pointless. + */ v4lchannel->tuner = n; channel->flags |= GST_TUNER_CHANNEL_FREQUENCY; channel->freq_multiplicator =