From c32ea3cb58a3edc65d3999c6f4188b6cf913a74c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Fri, 1 Apr 2016 22:41:51 +0300
Subject: [PATCH] clock: Return FALSE in all paths that don't set out
 parameters in gst_clock_add_observation_unapplied()

It returned TRUE when regression failed, while not setting any of the out
parameters. This caused uninitialized data from the stack to be used for
setting the clock calibration.
---
 gst/gstclock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gst/gstclock.c b/gst/gstclock.c
index 7e9be2f6c1..3f6d89164a 100644
--- a/gst/gstclock.c
+++ b/gst/gstclock.c
@@ -1474,7 +1474,7 @@ invalid:
   {
     /* no valid regression has been done, ignore the result then */
     GST_CLOCK_SLAVE_UNLOCK (clock);
-    return TRUE;
+    return FALSE;
   }
 }