From c2492b3a6b7b06906272fcd78ab29400f842fca5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 29 Jan 2015 16:30:34 +0100
Subject: [PATCH] glcolorconvert: Add FIXME comment about possibility of
 non-Apple YCbCr422 rectangular textures

---
 gst-libs/gst/gl/gstglcolorconvert.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gst-libs/gst/gl/gstglcolorconvert.c b/gst-libs/gst/gl/gstglcolorconvert.c
index 50592ae218..53e8c9d89e 100644
--- a/gst-libs/gst/gl/gstglcolorconvert.c
+++ b/gst-libs/gst/gl/gstglcolorconvert.c
@@ -850,6 +850,10 @@ _YUV_to_RGB (GstGLColorConvert * convert)
 
   if (in_tex_rectangular && apple_ycbcr
       && gst_buffer_n_memory (convert->inbuf) == 1) {
+    /* FIXME: We should probably also check if tex_target actually is using
+     * the Apple YCbCr422 extension. It could also be a normal UYVY texture
+     * with RB or Lum/Alpha
+     */
     info->frag_prog =
         g_strdup_printf (frag_APPLE_YUV_TO_RGB, pixel_order[0], pixel_order[1],
         pixel_order[2], pixel_order[3]);