From c2224b805941bd77b57f24e7b86f0a5ba3113135 Mon Sep 17 00:00:00 2001 From: Vineeth T M Date: Tue, 21 Oct 2014 14:43:30 +0530 Subject: [PATCH] videotestsrc: assertion error timestamp_offset is being declared as an int64 variable, for which the min value of G_MININT64 is -9223372036854775808 Changing the minimum and maximum limit for the offset variable. https://bugzilla.gnome.org/show_bug.cgi?id=738568 --- gst/videotestsrc/gstvideotestsrc.c | 5 +++-- gst/videotestsrc/gstvideotestsrc.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gst/videotestsrc/gstvideotestsrc.c b/gst/videotestsrc/gstvideotestsrc.c index 94013f9856..b4787cf6d6 100644 --- a/gst/videotestsrc/gstvideotestsrc.c +++ b/gst/videotestsrc/gstvideotestsrc.c @@ -184,8 +184,9 @@ gst_video_test_src_class_init (GstVideoTestSrcClass * klass) DEFAULT_PATTERN, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_object_class_install_property (gobject_class, PROP_TIMESTAMP_OFFSET, g_param_spec_int64 ("timestamp-offset", "Timestamp offset", - "An offset added to timestamps set on buffers (in ns)", G_MININT64, - G_MAXINT64, 0, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); + "An offset added to timestamps set on buffers (in ns)", 0, + (G_MAXLONG == G_MAXINT64) ? G_MAXINT64 : (G_MAXLONG * GST_SECOND - 1), + 0, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); g_object_class_install_property (gobject_class, PROP_IS_LIVE, g_param_spec_boolean ("is-live", "Is Live", "Whether to act as a live source", DEFAULT_IS_LIVE, diff --git a/gst/videotestsrc/gstvideotestsrc.h b/gst/videotestsrc/gstvideotestsrc.h index 1c77a8e4ed..c43c2e1e88 100644 --- a/gst/videotestsrc/gstvideotestsrc.h +++ b/gst/videotestsrc/gstvideotestsrc.h @@ -135,6 +135,7 @@ struct _GstVideoTestSrc { gint y_invert; /* private */ + /* FIXME 2.0: Change type to GstClockTime */ gint64 timestamp_offset; /* base offset */ /* running time and frames for current caps */