From c14a2d7d6d5873746a1faa71e0bac119ff06f7ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 28 May 2024 11:52:39 +0300 Subject: [PATCH] video: Document UL_LR / UR_LL video orientation methods correctly They're not flipping along the diagonal axis but a flip and rotation. Part-of: --- girs/GstVideo-1.0.gir | 4 ++-- subprojects/gst-plugins-base/gst-libs/gst/video/video.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/girs/GstVideo-1.0.gir b/girs/GstVideo-1.0.gir index 3268765c20..f0ac89363c 100644 --- a/girs/GstVideo-1.0.gir +++ b/girs/GstVideo-1.0.gir @@ -12889,10 +12889,10 @@ operation of video-sources or operators. Flip vertically - Flip across upper left/lower right diagonal + Rotate counter-clockwise 90 degrees and flip vertically - Flip across upper right/lower left diagonal + Rotate clockwise 90 degrees and flip vertically Select flip method based on image-orientation tag diff --git a/subprojects/gst-plugins-base/gst-libs/gst/video/video.h b/subprojects/gst-plugins-base/gst-libs/gst/video/video.h index b488f222a1..4f2a914a6d 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/video/video.h +++ b/subprojects/gst-plugins-base/gst-libs/gst/video/video.h @@ -68,8 +68,8 @@ struct _GstVideoAlignment * @GST_VIDEO_ORIENTATION_90L: Rotate counter-clockwise 90 degrees * @GST_VIDEO_ORIENTATION_HORIZ: Flip horizontally * @GST_VIDEO_ORIENTATION_VERT: Flip vertically - * @GST_VIDEO_ORIENTATION_UL_LR: Flip across upper left/lower right diagonal - * @GST_VIDEO_ORIENTATION_UR_LL: Flip across upper right/lower left diagonal + * @GST_VIDEO_ORIENTATION_UL_LR: Rotate counter-clockwise 90 degrees and flip vertically + * @GST_VIDEO_ORIENTATION_UR_LL: Rotate clockwise 90 degrees and flip vertically * @GST_VIDEO_ORIENTATION_AUTO: Select flip method based on image-orientation tag * @GST_VIDEO_ORIENTATION_CUSTOM: Current status depends on plugin internal setup *