From bf10d33b9b95856aabbc12dfa7c5ede50a27b38c Mon Sep 17 00:00:00 2001 From: Jimmy Ohn Date: Tue, 20 Jan 2015 00:32:00 +0000 Subject: [PATCH] pulsesink: Free format_info in query_getcaps If we can not create probe stream in query_getcaps function, it will appear memory leakage from format info. The following patch prevent memory leakage in pulsesink. https://bugzilla.gnome.org/show_bug.cgi?id=743178 --- ext/pulse/pulsesink.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index c20b0a0f85..abad2b806d 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -2164,13 +2164,14 @@ gst_pulsesink_query_getcaps (GstPulseSink * psink, GstCaps * filter) pbuf->probe_stream = gst_pulsesink_create_probe_stream (psink, pbuf, format); + + pa_format_info_free (format); + if (!pbuf->probe_stream) { GST_WARNING_OBJECT (psink, "Could not create probe stream"); goto unlock; } - pa_format_info_free (format); - stream = pbuf->probe_stream; }