give useful warning when not unique

Original commit message from CVS:
give useful warning when not unique
This commit is contained in:
Thomas Vander Stichele 2002-04-21 14:16:36 +00:00
parent 100cd3ca19
commit bede14df34

View file

@ -352,8 +352,13 @@ gst_bin_add (GstBin *bin, GstElement *element)
g_return_if_fail (GST_ELEMENT_PARENT (element) == NULL); g_return_if_fail (GST_ELEMENT_PARENT (element) == NULL);
/* then check to see if the element's name is already taken in the bin */ /* then check to see if the element's name is already taken in the bin */
g_return_if_fail (gst_object_check_uniqueness (bin->children, GST_ELEMENT_NAME (element)) == if (gst_object_check_uniqueness (bin->children,
TRUE); GST_ELEMENT_NAME (element)) == FALSE)
{
g_warning ("Name %s is not unique in bin %s, not adding\n",
GST_ELEMENT_NAME (element), GST_ELEMENT_NAME (bin));
return;
}
/* set the element's parent and add the element to the bin's list of children */ /* set the element's parent and add the element to the bin's list of children */
gst_object_set_parent (GST_OBJECT (element), GST_OBJECT (bin)); gst_object_set_parent (GST_OBJECT (element), GST_OBJECT (bin));