From bdda4bb6897f7db2bf6a8200ff86694eecf72b15 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Sat, 28 Jun 2014 09:34:05 -0300 Subject: [PATCH] aggregator: always store or unref the buffer on the _chain function Otherwise it leaks, and it is very common to go to flushing when the pipeline is stopping, leaking a buffer. --- gst-libs/gst/base/gstaggregator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst-libs/gst/base/gstaggregator.c b/gst-libs/gst/base/gstaggregator.c index 67ba269b38..fc949eafde 100644 --- a/gst-libs/gst/base/gstaggregator.c +++ b/gst-libs/gst/base/gstaggregator.c @@ -1158,12 +1158,14 @@ _chain (GstPad * pad, GstObject * object, GstBuffer * buffer) flushing: + gst_buffer_unref (buffer); GST_DEBUG_OBJECT (aggpad, "We are flushing"); return GST_FLOW_FLUSHING; eos: + gst_buffer_unref (buffer); GST_DEBUG_OBJECT (pad, "We are EOS already..."); return GST_FLOW_EOS;