From bab2f3c92b32b82eff7112baa7765935d8c4025e Mon Sep 17 00:00:00 2001 From: Marc Leeman Date: Mon, 28 Jan 2013 12:23:41 +0100 Subject: [PATCH] rtp: remove payload requirements from selected depayloaders encoding name is required in the caps and is a better fit for autoplugging than the pt value. Hardware manufacturers have a bad habit of skimming through RFCs and in this case; use unassigned numbers for encoders instead of dynamic numbers. In essence, this patch will add support for a lot of Bosch hardware encoders without breaking autoplugging. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=639292 --- gst/rtp/gstrtph263depay.c | 1 - gst/rtp/gstrtph263pdepay.c | 2 -- gst/rtp/gstrtph264depay.c | 1 - gst/rtp/gstrtpmp4vdepay.c | 1 - 4 files changed, 5 deletions(-) diff --git a/gst/rtp/gstrtph263depay.c b/gst/rtp/gstrtph263depay.c index 2265082978..82ad39de43 100644 --- a/gst/rtp/gstrtph263depay.c +++ b/gst/rtp/gstrtph263depay.c @@ -57,7 +57,6 @@ static GstStaticPadTemplate gst_rtp_h263_depay_sink_template = "clock-rate = (int) 90000, " "encoding-name = (string) \"H263\"; " "application/x-rtp, " "media = (string) \"video\", " - "payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", " "clock-rate = (int) 90000, " "encoding-name = (string) \"H263\"") ); diff --git a/gst/rtp/gstrtph263pdepay.c b/gst/rtp/gstrtph263pdepay.c index 567ceb58a5..e788e2f6e8 100644 --- a/gst/rtp/gstrtph263pdepay.c +++ b/gst/rtp/gstrtph263pdepay.c @@ -39,7 +39,6 @@ static GstStaticPadTemplate gst_rtp_h263p_depay_sink_template = GST_PAD_ALWAYS, GST_STATIC_CAPS ("application/x-rtp, " "media = (string) \"video\", " - "payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", " "clock-rate = (int) [1, MAX], " "encoding-name = (string) \"H263-1998\"; " /* optional params */ @@ -65,7 +64,6 @@ static GstStaticPadTemplate gst_rtp_h263p_depay_sink_template = */ "application/x-rtp, " "media = (string) \"video\", " - "payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", " "clock-rate = (int) [1, MAX], " "encoding-name = (string) \"H263-2000\" " /* optional params */ diff --git a/gst/rtp/gstrtph264depay.c b/gst/rtp/gstrtph264depay.c index 0e41883125..64f8c8e66c 100644 --- a/gst/rtp/gstrtph264depay.c +++ b/gst/rtp/gstrtph264depay.c @@ -55,7 +55,6 @@ GST_STATIC_PAD_TEMPLATE ("sink", GST_PAD_ALWAYS, GST_STATIC_CAPS ("application/x-rtp, " "media = (string) \"video\", " - "payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", " "clock-rate = (int) 90000, " "encoding-name = (string) \"H264\"") /** optional parameters **/ /* "profile-level-id = (string) ANY, " */ diff --git a/gst/rtp/gstrtpmp4vdepay.c b/gst/rtp/gstrtpmp4vdepay.c index 158cb48907..3ff58d5149 100644 --- a/gst/rtp/gstrtpmp4vdepay.c +++ b/gst/rtp/gstrtpmp4vdepay.c @@ -43,7 +43,6 @@ GST_STATIC_PAD_TEMPLATE ("sink", GST_PAD_ALWAYS, GST_STATIC_CAPS ("application/x-rtp, " "media = (string) \"video\", " - "payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", " "clock-rate = (int) [1, MAX ], " "encoding-name = (string) \"MP4V-ES\"" /* All optional parameters *