From b9011f3541e1da518df5b0857547d833555cc49e Mon Sep 17 00:00:00 2001 From: Philippe Normand Date: Sun, 4 Dec 2022 11:44:17 +0000 Subject: [PATCH] flacparse: Fix handling of headers advertising 32bps According to the flac bitstream format specification, the sample size in bits corresponding to `111` is 32 bits per sample. https://xiph.org/flac/format.html#frame_header Part-of: --- subprojects/gst-plugins-good/gst/audioparsers/gstflacparse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-good/gst/audioparsers/gstflacparse.c b/subprojects/gst-plugins-good/gst/audioparsers/gstflacparse.c index 8fca410899..a53b7ebc77 100644 --- a/subprojects/gst-plugins-good/gst/audioparsers/gstflacparse.c +++ b/subprojects/gst-plugins-good/gst/audioparsers/gstflacparse.c @@ -377,7 +377,7 @@ gst_flac_parse_stop (GstBaseParse * parse) return TRUE; } -static const guint8 sample_size_table[] = { 0, 8, 12, 0, 16, 20, 24, 0 }; +static const guint8 sample_size_table[] = { 0, 8, 12, 0, 16, 20, 24, 32 }; static const guint16 blocksize_table[16] = { 0, 192, 576 << 0, 576 << 1, 576 << 2, 576 << 3, 0, 0, @@ -449,7 +449,7 @@ gst_flac_parse_frame_header_is_valid (GstFlacParse * flacparse, /* bits per sample */ bps = gst_bit_reader_get_bits_uint8_unchecked (&reader, 3); - if (bps == 0x03 || bps == 0x07) { + if (bps == 0x03) { goto error; } else if (bps == 0 && flacparse->bps == 0) { goto need_streaminfo;