From b75b17cf738bd8263a23f4f0abc237e4541e805b Mon Sep 17 00:00:00 2001
From: Thibault Saunier <tsaunier@igalia.com>
Date: Mon, 8 Jan 2024 11:24:17 -0300
Subject: [PATCH] ges: pipeline: Port to encodebin2

This way we can use muxing sinks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5915>
---
 .../gst-editing-services/ges/ges-pipeline.c   | 32 ++++++++++++++-----
 1 file changed, 24 insertions(+), 8 deletions(-)

diff --git a/subprojects/gst-editing-services/ges/ges-pipeline.c b/subprojects/gst-editing-services/ges/ges-pipeline.c
index 6d271ba17f..641b95e54c 100644
--- a/subprojects/gst-editing-services/ges/ges-pipeline.c
+++ b/subprojects/gst-editing-services/ges/ges-pipeline.c
@@ -254,6 +254,7 @@ _timeline_track_removed_cb (GESTimeline * timeline, GESTrack * track,
   _unlink_track (pipeline, track);
 }
 
+
 static void
 ges_pipeline_constructed (GObject * object)
 {
@@ -409,7 +410,8 @@ ges_pipeline_init (GESPipeline * self)
   self->priv->playsink =
       gst_element_factory_make ("playsink", "internal-sinks");
   self->priv->encodebin =
-      gst_element_factory_make ("encodebin", "internal-encodebin");
+      gst_element_factory_make ("encodebin2", "internal-encodebin");
+
   g_object_set (self->priv->encodebin, "avoid-reencoding", TRUE, NULL);
 
   if (G_UNLIKELY (self->priv->playsink == NULL))
@@ -626,8 +628,8 @@ ges_pipeline_change_state (GstElement * element, GstStateChange transition)
 
       for (tmp = self->priv->not_rendered_tracks; tmp; tmp = tmp->next)
         gst_element_set_locked_state (tmp->data, FALSE);
-    }
       break;
+    }
     case GST_STATE_CHANGE_PAUSED_TO_PLAYING:
     {
       GstElement *queue = gst_bin_get_by_name (GST_BIN (self->priv->playsink),
@@ -1266,19 +1268,33 @@ ges_pipeline_set_mode (GESPipeline * pipeline, GESPipelineFlags mode)
       GST_ERROR_OBJECT (pipeline, "Output URI not set !");
       return FALSE;
     }
+
     if (!gst_bin_add (GST_BIN_CAST (pipeline), pipeline->priv->encodebin)) {
       GST_ERROR_OBJECT (pipeline, "Couldn't add encodebin");
       return FALSE;
     }
-    if (!gst_bin_add (GST_BIN_CAST (pipeline), pipeline->priv->urisink)) {
-      GST_ERROR_OBJECT (pipeline, "Couldn't add URI sink");
-      return FALSE;
+
+    /* We know that encodebin2 will add its src pads as soon as the profile is
+     * set, so link the sink to it if it has a pad */
+    if (pipeline->priv->encodebin->numsrcpads > 0) {
+      if (pipeline->priv->encodebin->numsrcpads > 1) {
+        GST_WARNING_OBJECT (pipeline,
+            "Encodebin has more than one srcpad, this is not supported yet");
+      }
+
+      if (!gst_bin_add (GST_BIN_CAST (pipeline), pipeline->priv->urisink)) {
+        GST_ERROR_OBJECT (pipeline, "Couldn't add URI sink");
+        return FALSE;
+      }
+
+      gst_element_link_pads_full (pipeline->priv->encodebin, "src_0",
+          pipeline->priv->urisink, "sink", GST_PAD_LINK_CHECK_NOTHING);
+    } else {
+      GST_INFO_OBJECT (pipeline,
+          "Using an muxing sink, not adding any sink element");
     }
     g_object_set (pipeline->priv->encodebin, "avoid-reencoding",
         !(!(mode & GES_PIPELINE_MODE_SMART_RENDER)), NULL);
-
-    gst_element_link_pads_full (pipeline->priv->encodebin, "src",
-        pipeline->priv->urisink, "sink", GST_PAD_LINK_CHECK_NOTHING);
   }
 
   if (pipeline->priv->timeline) {