From b692539b55063f22acb4365af9891b432e9501d2 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Fri, 2 May 2014 09:49:32 +0100 Subject: [PATCH] qtdemux: guard against invalid frame size to avoid division by 0 Coverity 1139690 --- gst/isomp4/qtdemux.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c index 8732f1edb3..613edad576 100644 --- a/gst/isomp4/qtdemux.c +++ b/gst/isomp4/qtdemux.c @@ -3885,6 +3885,9 @@ gst_qtdemux_clip_buffer (GstQTDemux * qtdemux, QtDemuxStream * stream, } else goto wrong_type; + if (frame_size <= 0) + goto bad_frame_size; + /* we can only clip if we have a valid pts */ pts = GST_BUFFER_PTS (buf); if (G_UNLIKELY (!GST_CLOCK_TIME_IS_VALID (pts))) @@ -3953,6 +3956,11 @@ wrong_type: GST_DEBUG_OBJECT (qtdemux, "unknown stream type"); return buf; } +bad_frame_size: + { + GST_DEBUG_OBJECT (qtdemux, "bad frame size"); + return buf; + } no_pts: { GST_DEBUG_OBJECT (qtdemux, "no pts on buffer");