From b6192a81bd79f295cdb7fd8a854f8188558c0c66 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 31 Jan 2006 18:46:15 +0000 Subject: [PATCH] gst/gstbin.c: Don't cache duration messages if we're not going to use or free them. Original commit message from CVS: * gst/gstbin.c: (bin_remove_messages), (bin_query_duration_done): Don't cache duration messages if we're not going to use or free them. --- ChangeLog | 6 ++++++ gst/gstbin.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 23b6ef33b5..640a89b214 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-01-31 Wim Taymans + + * gst/gstbin.c: (bin_remove_messages), (bin_query_duration_done): + Don't cache duration messages if we're not going to use or + free them. + 2006-01-31 Stefan Kost * docs/manual/advanced-dparams.xml: diff --git a/gst/gstbin.c b/gst/gstbin.c index 0869473741..21bc8e8917 100644 --- a/gst/gstbin.c +++ b/gst/gstbin.c @@ -629,7 +629,7 @@ bin_remove_messages (GstBin * bin, GstObject * src, GstMessageType types) gst_message_unref (message); } else { GST_DEBUG_OBJECT (GST_MESSAGE_SRC (message), - "not deleting message of types %d", types); + "not deleting message of type %d", GST_MESSAGE_TYPE (message)); } } } @@ -2187,11 +2187,13 @@ bin_query_duration_done (GstBin * bin, QueryFold * fold) GST_DEBUG_OBJECT (bin, "max duration %" G_GINT64_FORMAT, fold->max); +#if 0 /* and cache now */ GST_OBJECT_LOCK (bin); bin->messages = g_list_prepend (bin->messages, gst_message_new_duration (GST_OBJECT_CAST (bin), format, fold->max)); GST_OBJECT_UNLOCK (bin); +#endif } /* generic fold, return first valid result */