From b40bedb5975d5e2fa468f84f13d123752038722d Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Fri, 28 Apr 2023 04:28:24 +0900 Subject: [PATCH] wasapi2: Allows process loopback capture on Windows 10 As per MS documentation[1], it requires Windows 10 Build 20348 but it seems to be supported by old versions too [1] https://learn.microsoft.com/en-us/windows/win32/api/audioclientactivationparams/ ns-audioclientactivationparams-audioclient_process_loopback_params Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2524 Part-of: --- subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2util.c b/subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2util.c index d1e2e8bed1..44be018ee4 100644 --- a/subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2util.c +++ b/subprojects/gst-plugins-bad/sys/wasapi2/gstwasapi2util.c @@ -526,8 +526,10 @@ gst_wasapi2_can_process_loopback (void) * "Windows 11", since build number of "Windows 10 version 21H2" is * still 19044.XXX */ + + /* But other software enables this for build number 19041 or higher... */ if (osverinfo.dwMajorVersion > 10 || - (osverinfo.dwMajorVersion == 10 && osverinfo.dwBuildNumber >= 20348)) + (osverinfo.dwMajorVersion == 10 && osverinfo.dwBuildNumber >= 19041)) ret = TRUE; }