From af1986352b16aa9bc2f1b07c60860d78958aca23 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Tue, 4 Feb 2020 14:00:48 +1100 Subject: [PATCH] glviewconvert: fix a use-after-free with allocation params _free(params) followed by a params->align is a bad idea :) --- gst-libs/gst/gl/gstglviewconvert.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gst-libs/gst/gl/gstglviewconvert.c b/gst-libs/gst/gl/gstglviewconvert.c index 0228294a8a..d6e6cd9383 100644 --- a/gst-libs/gst/gl/gstglviewconvert.c +++ b/gst-libs/gst/gl/gstglviewconvert.c @@ -1982,7 +1982,6 @@ _gen_buffer (GstGLViewConvert * viewconvert, GstBuffer ** target) gst_object_unref (allocator); return FALSE; } - gst_gl_allocation_params_free ((GstGLAllocationParams *) params); gst_object_unref (allocator); meta = gst_buffer_add_video_meta_full (*target, 0, @@ -1995,6 +1994,8 @@ _gen_buffer (GstGLViewConvert * viewconvert, GstBuffer ** target) if (params->valign) gst_video_meta_set_alignment (meta, *params->valign); + gst_gl_allocation_params_free ((GstGLAllocationParams *) params); + return TRUE; }