From addb63586bad7a36d82caa9b30bd10445dd61264 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 4 Jan 2016 09:59:40 +0200 Subject: [PATCH] playback/player: player: Remove gst_player_new() and make gst_player_new_full() the normal constructor In very few cases the simple version was actually needed and having the parameters hidden by a _full() version caused application that actually needed it to not use it. --- playback/player/android/jni/player.c | 2 +- playback/player/gst-play/gst-play.c | 2 +- playback/player/gtk/gtk-play.c | 2 +- playback/player/ios/GstPlay/VideoViewController.m | 2 +- playback/player/qt/qgstplayer.cpp | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/playback/player/android/jni/player.c b/playback/player/android/jni/player.c index 133d97090f..ee537086aa 100644 --- a/playback/player/android/jni/player.c +++ b/playback/player/android/jni/player.c @@ -199,7 +199,7 @@ native_new (JNIEnv * env, jobject thiz) Player *player = g_new0 (Player, 1); player->renderer = gst_player_video_overlay_video_renderer_new (NULL); - player->player = gst_player_new_full (player->renderer, NULL); + player->player = gst_player_new (player->renderer, NULL); SET_CUSTOM_DATA (env, thiz, native_player_field_id, player); player->java_player = (*env)->NewGlobalRef (env, thiz); diff --git a/playback/player/gst-play/gst-play.c b/playback/player/gst-play/gst-play.c index 95b9d4fa1c..46f6d62a71 100644 --- a/playback/player/gst-play/gst-play.c +++ b/playback/player/gst-play/gst-play.c @@ -357,7 +357,7 @@ play_new (gchar ** uris, gdouble initial_volume) play->cur_idx = -1; play->player = - gst_player_new_full (NULL, gst_player_g_main_context_signal_dispatcher_new + gst_player_new (NULL, gst_player_g_main_context_signal_dispatcher_new (NULL)); g_signal_connect (play->player, "position-updated", diff --git a/playback/player/gtk/gtk-play.c b/playback/player/gtk/gtk-play.c index 0e6ac76f17..51d0bf0235 100644 --- a/playback/player/gtk/gtk-play.c +++ b/playback/player/gtk/gtk-play.c @@ -1732,7 +1732,7 @@ gtk_play_constructor (GType type, guint n_construct_params, create_ui (self); self->player = - gst_player_new_full (self->renderer, + gst_player_new (self->renderer, gst_player_g_main_context_signal_dispatcher_new (NULL)); g_signal_connect (self->player, "position-updated", diff --git a/playback/player/ios/GstPlay/VideoViewController.m b/playback/player/ios/GstPlay/VideoViewController.m index eda419c0e2..19c379926c 100644 --- a/playback/player/ios/GstPlay/VideoViewController.m +++ b/playback/player/ios/GstPlay/VideoViewController.m @@ -63,7 +63,7 @@ media_width = 320; media_height = 240; - player = gst_player_new_full (gst_player_video_overlay_video_renderer_new ((__bridge gpointer)(video_view)), NULL); + player = gst_player_new (gst_player_video_overlay_video_renderer_new ((__bridge gpointer)(video_view)), NULL); g_object_set (player, "uri", [uri UTF8String], NULL); gst_debug_set_threshold_for_name("gst-player", GST_LEVEL_TRACE); diff --git a/playback/player/qt/qgstplayer.cpp b/playback/player/qt/qgstplayer.cpp index b15347ff19..77112ef346 100644 --- a/playback/player/qt/qgstplayer.cpp +++ b/playback/player/qt/qgstplayer.cpp @@ -397,7 +397,7 @@ Player::Player(QObject *parent, VideoRenderer *renderer) , autoPlay_(false) { - player_ = gst_player_new_full(renderer ? renderer->renderer() : 0, + player_ = gst_player_new(renderer ? renderer->renderer() : 0, gst_player_qt_signal_dispatcher_new(this)); g_object_connect(player_,