diff --git a/ChangeLog b/ChangeLog index 0e22b3617c..610d824eb2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2004-03-04 David Schleef + + * testsuite/gst-lint: Add a check for bad signal names. + 2004-03-04 reviewed by David Schleef diff --git a/tests/old/testsuite/gst-lint b/tests/old/testsuite/gst-lint index 16ac951c1c..98a338485f 100755 --- a/tests/old/testsuite/gst-lint +++ b/tests/old/testsuite/gst-lint @@ -45,6 +45,7 @@ sub check_caps(); sub check_lib_deprecated(); sub check_typo(); sub check_explicit_caps(); +sub check_signals(); sub m_check_plugindir(); sub m_check_interfaces(); @@ -72,6 +73,7 @@ foreach $filename () { check_typo(); check_glibisms(); check_explicit_caps(); + check_signals(); # less important stuff @@ -508,3 +510,13 @@ sub check_explicit_caps() } } +# +# Check for - in signal names +# +sub check_signals() +{ + if (grep { /g_signal_new.*\".*-.*\"/; } @lines) { + print "E: g_signal_new() with a signal name with a - in it (we prefer _)\n" + } +} + diff --git a/testsuite/gst-lint b/testsuite/gst-lint index 16ac951c1c..98a338485f 100755 --- a/testsuite/gst-lint +++ b/testsuite/gst-lint @@ -45,6 +45,7 @@ sub check_caps(); sub check_lib_deprecated(); sub check_typo(); sub check_explicit_caps(); +sub check_signals(); sub m_check_plugindir(); sub m_check_interfaces(); @@ -72,6 +73,7 @@ foreach $filename () { check_typo(); check_glibisms(); check_explicit_caps(); + check_signals(); # less important stuff @@ -508,3 +510,13 @@ sub check_explicit_caps() } } +# +# Check for - in signal names +# +sub check_signals() +{ + if (grep { /g_signal_new.*\".*-.*\"/; } @lines) { + print "E: g_signal_new() with a signal name with a - in it (we prefer _)\n" + } +} +