From aa77cac8ecd9f2b736c5b9278c453114c14efcd3 Mon Sep 17 00:00:00 2001 From: Christoph Reiter Date: Tue, 22 May 2018 22:12:34 +0200 Subject: [PATCH] wasapi: Don't pass CoTaskMemFree to g_clear_pointer CoTaskMemFree has a different calling convention than GDestroyNotify and things crash at least with MinGW. https://bugzilla.gnome.org/show_bug.cgi?id=796280 --- sys/wasapi/gstwasapisink.c | 3 ++- sys/wasapi/gstwasapisrc.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/wasapi/gstwasapisink.c b/sys/wasapi/gstwasapisink.c index e06f07a18b..fc5a32f303 100644 --- a/sys/wasapi/gstwasapisink.c +++ b/sys/wasapi/gstwasapisink.c @@ -208,7 +208,8 @@ gst_wasapi_sink_finalize (GObject * object) { GstWasapiSink *self = GST_WASAPI_SINK (object); - g_clear_pointer (&self->mix_format, CoTaskMemFree); + CoTaskMemFree (self->mix_format); + self->mix_format = NULL; if (self->cached_caps != NULL) { gst_caps_unref (self->cached_caps); diff --git a/sys/wasapi/gstwasapisrc.c b/sys/wasapi/gstwasapisrc.c index 1dbbc82398..bf52062cd3 100644 --- a/sys/wasapi/gstwasapisrc.c +++ b/sys/wasapi/gstwasapisrc.c @@ -218,7 +218,8 @@ gst_wasapi_src_finalize (GObject * object) { GstWasapiSrc *self = GST_WASAPI_SRC (object); - g_clear_pointer (&self->mix_format, CoTaskMemFree); + CoTaskMemFree (self->mix_format); + self->mix_format = NULL; g_clear_pointer (&self->cached_caps, gst_caps_unref); g_clear_pointer (&self->positions, g_free);