From a88e63dd2ff8cb3991b79f140915810da9b5ca8d Mon Sep 17 00:00:00 2001
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: Wed, 1 Jul 2020 12:26:36 -0400
Subject: [PATCH] v4l2decoder: Improve debug tracing

Add some missing traces and move per-slice operation to TRACE level to
reduce the noise level.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>
---
 sys/v4l2codecs/gstv4l2decoder.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/sys/v4l2codecs/gstv4l2decoder.c b/sys/v4l2codecs/gstv4l2decoder.c
index d6b26be620..d00706eeca 100644
--- a/sys/v4l2codecs/gstv4l2decoder.c
+++ b/sys/v4l2codecs/gstv4l2decoder.c
@@ -536,6 +536,8 @@ gst_v4l2_decoder_queue_sink_mem (GstV4l2Decoder * self,
     .flags = V4L2_BUF_FLAG_REQUEST_FD | flags,
   };
 
+  GST_TRACE_OBJECT (self, "Queueing bitstream buffer %i", buf.index);
+
   if (self->mplane) {
     buf.length = 1;
     buf.m.planes = &plane;
@@ -566,6 +568,8 @@ gst_v4l2_decoder_queue_src_buffer (GstV4l2Decoder * self, GstBuffer * buffer,
     .index = gst_v4l2_codec_buffer_get_index (buffer),
   };
 
+  GST_TRACE_OBJECT (self, "Queuing picture buffer %i", buf.index);
+
   if (self->mplane) {
     buf.length = gst_buffer_n_memory (buffer);
     buf.m.planes = planes;
@@ -611,6 +615,8 @@ gst_v4l2_decoder_dequeue_sink (GstV4l2Decoder * self)
     return FALSE;
   }
 
+  GST_TRACE_OBJECT (self, "Dequeued bitstream buffer %i", buf.index);
+
   return TRUE;
 }
 
@@ -636,6 +642,9 @@ gst_v4l2_decoder_dequeue_src (GstV4l2Decoder * self, guint32 * out_frame_num)
   }
 
   *out_frame_num = buf.timestamp.tv_usec;
+
+  GST_TRACE_OBJECT (self, "Dequeued picture buffer %i", buf.index);
+
   return TRUE;
 }
 
@@ -835,7 +844,7 @@ gst_v4l2_request_free (GstV4l2Request * request)
     return;
   }
 
-  GST_DEBUG_OBJECT (decoder, "Recycling request %p.", request);
+  GST_TRACE_OBJECT (decoder, "Recycling request %p.", request);
 
   ret = ioctl (request->fd, MEDIA_REQUEST_IOC_REINIT, NULL);
   if (ret < 0) {
@@ -855,7 +864,7 @@ gst_v4l2_request_queue (GstV4l2Request * request)
 {
   gint ret;
 
-  GST_DEBUG_OBJECT (request->decoder, "Queuing request %p.", request);
+  GST_TRACE_OBJECT (request->decoder, "Queuing request %p.", request);
 
   ret = ioctl (request->fd, MEDIA_REQUEST_IOC_QUEUE, NULL);
   if (ret < 0) {