From a846e84349f60c6eb694a741b8f6da70c735be24 Mon Sep 17 00:00:00 2001
From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Fri, 2 May 2014 14:06:25 +0100
Subject: [PATCH] rtspsrc: remove duplicate test

item was dereference previously.

While there, reorder some test for faster early out.

Coverity 1139844
---
 gst/rtsp/gstrtspsrc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gst/rtsp/gstrtspsrc.c b/gst/rtsp/gstrtspsrc.c
index de456267bb..ae875bf812 100644
--- a/gst/rtsp/gstrtspsrc.c
+++ b/gst/rtsp/gstrtspsrc.c
@@ -5132,8 +5132,7 @@ gst_rtspsrc_parse_digest_challenge (GstRTSPConnection * conn,
     } else
       value = NULL;
 
-    if (item && (strcmp (item, "stale") == 0) &&
-        value && (strcmp (value, "TRUE") == 0))
+    if (value && strcmp (item, "stale") == 0 && strcmp (value, "TRUE") == 0)
       *stale = TRUE;
     gst_rtsp_connection_set_auth_param (conn, item, value);
     g_free (item);